-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document XMLHttpRequestUpload #25671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing word
Co-authored-by: dawei-wang <dawei-wang@users.noreply.github.com>
9d6cfe0
to
7318754
Compare
First impression: Looks great! Do we want to repeat the (rich) example on all sub pages, though? |
I was unsure. i can keep only the js with some of the events? |
I think we often put snippets. Maybe something like this for the loadend page: ExamplesUsing the loadend eventYou can use the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits. I think this looks good otherwise. It is mostly analog to XHR, I believe.
files/en-us/web/api/xmlhttprequestupload/loadend_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/xmlhttprequestupload/loadstart_event/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/xmlhttprequestupload/timeout_event/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Co-authored-by: Florian Scholz <fs@florianscholz.com>
Description
Document
XMLHttpRequestUpload
and its eventsMotivation
openwebdocs/project#152